Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 Check-in "Input Data" Button connect Data Entry Modal + Data Entry Modal Match Design #47

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

tig-github
Copy link
Member

Authors:
bobbyzhong, tig-github

What does this PR contain?

Check-in "Input Data" Button connect Data Entry Modal + Data Entry Modal Match Design
Updated functionality to match design

How did you test these changes?

  • Checked DBMS to ensure unusual items were included in volunteer entries
  • Checked with custom unusual item entry arrays
  • Checked DBMS to verify unusual items format

Closes #41

// parses unusual items input - single entries come as strings, multiple entries come as strings of the form {item1, item2... itemn}
useEffect(() => {
formatUnusualItems();
}, []);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <react-hooks/exhaustive-deps> reported by reviewdog 🐶
React Hook useEffect has a missing dependency: 'formatUnusualItems'. Either include it or remove the dependency array.

@NwinNwin NwinNwin merged commit e551408 into main Feb 5, 2024
2 checks passed
@NwinNwin NwinNwin deleted the 41-modal-branch branch February 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check-in "Input Data" Button connect Data Entry Modal + Data Entry Modal Match Design
4 participants