Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Dashboard Match Design and Flow #54

Merged
merged 7 commits into from
Feb 5, 2024

Conversation

phillipcutter
Copy link
Contributor

Authors: @phillipcutter @eachen1010

What does this PR contain?

  1. Updated DummyEvents page to match lo-fi design and flow from Figma designs
    • Sidebar with clickable buttons to go home or view profile (doesn't do anything currently)
    • Create event button opens previous modal to create an event (some fields are set to defaults for testing, like date/time)
    • Select allows selecting events, with a new delete button that appears
      • Selecting an event and clicking "Delete" brings up a confirmation modal
      • Selecting no events and clicking "Delete" exits selection mode
      • A new "Deselect all" button replaces "Create event" and, when clicked, deselects all events and exits selection mode
    • Clicking any event opens a modal with more information

How did you test these changes?

We ran the backend locally and tested creating and deleting events to ensure it was working properly (the issue I mentioned during today's dev meeting was caused by me not pulling the latest backend changes lol). We also tested various edge cases, such as clicking delete with no events selected.

Attach images (if applicable)

image
/events page

image
Create new event modal (UI of form is still a placeholder)

image
Detailed event modal (triggered when clicking on an event)

image
Selecting events

image
Permanently delete confirmation modal

image
Deleted toast

Closes #40

@phillipcutter phillipcutter linked an issue Feb 4, 2024 that may be closed by this pull request
Copy link
Collaborator

@Aokijiop Aokijiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job matching the design! Also, thank you for going back and separating the modals into different components! The PSA was more meant for future tasks but you guys going back and fixing it with your current issue is really helpful for us!

@Aokijiop Aokijiop merged commit 3e786bd into main Feb 5, 2024
3 checks passed
@NwinNwin NwinNwin deleted the 40-event-dashboard-match-design-and-flow branch February 20, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Dashboard Match Design and Flow
3 participants