Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enableSeekPause option #82

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

EastSun5566
Copy link

Hi @ctd1500 ,

Thanks for the great plugin!

After I press the right/left arrow keys to seek video will cause a pause when it is playing.
I think just using the currentTime method to seek will keep playing state. No need to keep track current playing state.

Please let me know what you think. Thank you!

@ctd1500
Copy link
Owner

ctd1500 commented Dec 1, 2022

The pause/play is there for consistency with how the seekbar works when using the mouse: #41.

You could add a new option like enableSeekPause, default to true for compatibility.

@EastSun5566
Copy link
Author

Thank you for explaining that!

enableSeekPause sounds like a good option. I will turn this PR into a draft and then implement it.

@EastSun5566 EastSun5566 changed the title fix: keep playing state after seek WIP: feat: add enableSeekPause option Dec 1, 2022
@EastSun5566 EastSun5566 force-pushed the fix/keep-playing-state-after-seek branch from 68458e6 to 63ef759 Compare December 1, 2022 16:25
@EastSun5566 EastSun5566 changed the title WIP: feat: add enableSeekPause option feat: add enableSeekPause option Dec 24, 2022
@EastSun5566
Copy link
Author

Hi @ctd1500 ,

Sorry for being a little bit late.

I added the enableSeekPause option for the previous discussion & also update README.md.
Please take a look & let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants