Ces 984 customergroup product fixes #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this change prevent the component to be processed
herveatcti
commented
Nov 3, 2023
herveatcti
commented
Nov 3, 2023
| @@ -125,7 +125,7 @@ public function getImportRowFailures(Importer $import, $importLines) | |||
| { | |||
| $failedRows = []; | |||
| // Creates a validation model and runs the import data through so we can find which rows would fail | |||
| $validation = $import->createImportModel(); | |||
| $validation = $import->getImportModel(); | |||
There was a problem hiding this comment.
this change implies we won't be backward compatible @paulpartington. Was not sure where the change came from to be honest.
herveatcti
commented
Nov 3, 2023
| if (isset($group['name'])) { | ||
| $this->createCustomerGroup($group['name'], $taxClassId); | ||
| } | ||
| $this->validateGroupName($group); |
There was a problem hiding this comment.
essentially, this change is so that when the group is not created, we can work out why without having to get into the code
…mport test we have in the configurator
benjamenjohnsondev
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.