Skip to content

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Oct 1, 2025

This PR fixes errors for cases when pre-aggregation time dimension references member from other cubes.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review October 1, 2025 12:42
@KSDaemon KSDaemon requested a review from a team as a code owner October 1, 2025 12:42
@KSDaemon KSDaemon force-pushed the feat/proxy-td-in-pre-aggs branch from 1648ae1 to d84792b Compare October 15, 2025 18:22
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.76%. Comparing base (f556b62) to head (cf8e286).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f556b62) and HEAD (cf8e286). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f556b62) HEAD (cf8e286)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10020       +/-   ##
===========================================
- Coverage   77.13%   48.76%   -28.38%     
===========================================
  Files         440      196      -244     
  Lines       89307    15826    -73481     
  Branches     3101     3101               
===========================================
- Hits        68889     7717    -61172     
+ Misses      20029     7720    -12309     
  Partials      389      389               
Flag Coverage Δ
cube-backend 48.76% <0.00%> (-0.01%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the feat/proxy-td-in-pre-aggs branch from 73b3f99 to d84792b Compare October 16, 2025 16:05
@KSDaemon KSDaemon requested a review from a team as a code owner October 16, 2025 16:13
@github-actions github-actions bot added driver:postgres Issues relating to the Postgres driver data source driver labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver driver:postgres Issues relating to the Postgres driver javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant