Cookies: define sameSite value

cubiest · Jan 31, 2023 · edf2dba · edf2dba
1 parent 6c2f92d
commit edf2dba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/assets/invi/partials/_sidebar.scss b/assets/invi/partials/_sidebar.scss
@@ -98,7 +98,7 @@ Sidebar Styles
         display: flex;
         justify-content: space-between;
         align-items: center;
-        border-bottom: 1px solid $cp-container-3; // FIXME: lighten($cp-container-3, 5%); -> variable is hex string, not color
+        border-bottom: 1px solid $cp-container-3; // FIXME (https://github.com/gohugoio/hugo/issues/10632): lighten($cp-container-3, 5%); -> variable is hex string, not color
         padding: 0 20px;
 
         img {
@@ -160,9 +160,9 @@ Sidebar Styles
 
                     li {
                         a {
-                            background-color: $cp-container-3; // FIXME: darken($cp-container-3, 5%); -> variable is hex string, not color
+                            background-color: $cp-container-3; // FIXME (https://github.com/gohugoio/hugo/issues/10632): darken($cp-container-3, 5%); -> variable is hex string, not color
                             padding-left: 62px;
-                            border-bottom: 1px solid $cp-container-3-border;// FIXME: lighten($cp-container-3-border, 2%); -> variable is hex string, not color
+                            border-bottom: 1px solid $cp-container-3-border;// FIXME (https://github.com/gohugoio/hugo/issues/10632): lighten($cp-container-3-border, 2%); -> variable is hex string, not color
                             font-size: .8rem;
 
                             &:hover {

diff --git a/static/js/invi.js b/static/js/invi.js
@@ -15,9 +15,7 @@ $(document).ready(function () {
         var notification = $('#cookie-notification');
         if (notification.length) {
             var allow_other_cookies = Cookies.get("allow-nonfunctional-website-cookies");
-            if (allow_other_cookies === null || typeof allow_other_cookies === "undefined") {
-                // TODO: change html.background-color to `whitesmoke`
-            } else {
+            if (allow_other_cookies !== null && typeof allow_other_cookies !== "undefined") {
                 notification.hide();
             }
         }
@@ -213,20 +211,19 @@ $(document).ready(function () {
  * @return {boolean} whether to accept cookies beyond the necessary functional ones.
  */
 function handleWebsiteCookies(accept) {
-    Cookies.set("allow-nonfunctional-website-cookies", accept, { expires: 730 }); // i.e. in 2 years
+    Cookies.set("allow-nonfunctional-website-cookies", accept, { expires: 730, sameSite: 'lax' }); // i.e. in 2 years
 
     var notification = $("#cookie-notification");
     if (notification.length) {
         notification.hide();
     }
-    // TODO: change html.background-color to `#444F60`
 }
 
 /**
  * acceptCookiesAndShowYouTubeVideo user clicked on youtube cookie consent button beneath video placeholder.
  */
 function acceptCookiesAndShowYouTubeVideo() {
-    Cookies.set("allow-youtube-cookies", true, { expires: 730 }); // i.e. in 2 years
+    Cookies.set("allow-youtube-cookies", true, { expires: 730, sameSite: 'lax' }); // i.e. in 2 years
 
     // hide consent notification
     var notification = document.getElementsByClassName("video-embed-notification")[0];