This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Handle symlinks (to files/dirs to be deleted) when using 'cuckoo clean' command #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `cuckoo clean`, if one of the directories under `$CWD/storage/` is a symlink, then an exception will be thrown and the files/directories that the symlink points to will not be deleted. The change here is one line of code and what it does is: - The real path of the directory (whether a regular dir or a soft link) is retrieved first and any files/directories will recursively be deleted afterwards.
Handle symlinks when using 'cuckoo clean'
soutzis
changed the title
soutzis
changed the title
soutzis
changed the title
soutzis
changed the title
* removes m2crypto and replaces with cryptography - Uses https://github.com/pyca/cryptography instead of m2crypto - Copy of @utkonos' commit (cuckoosandbox#2938) * Update static.py * Update requirements.rst
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have added/changed is:
One line of code.
The goal of my change is:
Enhancement closes #3086
When using
$ cuckoo clean, if one of the directories under$CWD/storage/is a soft-link, then an exception will be thrown and the files/directories that the soft-link points to will not be deleted.What I have tested about my change is:
Before the change:
After the change:
