This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Correctly parsing URIs #3199
Open
Correctly parsing URIs #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html
What I have added/changed is:
Some logic to address edge cases created by certain malware... unfortunately I do not have a public hash to share for recreation.
The goal of my change is:
The TCP data captured from network traffic was parsed in the network processing module with the URI containing
<protocol>://<netloc>/<path>, which then caused issues putting the URL back together here. The unparsed URI would then look like<protocol>://<netloc>/<protocol>://<netloc>/<path>which is an invalid URI.The goal of my change is to parse this URI extracted from the pcap correctly before it goes into the
urlunparsemethod.What I have tested about my change is:
I tested with the .pcaps generated by the malware that displayed this behaviour, and this change fixes it.
Also this happens in the KVM machinery.