Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify scenario describing interactive debugging #916

Merged
merged 3 commits into from
Dec 23, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Dec 23, 2023

Summary

Clean up interactive debugging scenario. Also, allow it to run on JRuby.

Details

  • Remove stream configuration that is no longer needed
  • Remove obsolete warning about binding.pry and related code
  • Mark debugging scenario as supported on JRuby

Motivation and Context

While debugging #910, I noticed some obsolete bits in the scenario that is failing with upcoming Ruby 3.3.

How Has This Been Tested?

I ran the scenario again after applying the simplifications. I also checked that it passed on JRuby.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

mvz added 3 commits December 23, 2023 21:11
The scenario works fine without an extra statement after the call to
binding.pry.
@mvz mvz merged commit 0e95bbf into main Dec 23, 2023
15 checks passed
@mvz mvz deleted the simplify-interactive-scenario branch December 23, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant