Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

150 add ci environment implementation in go #151

Merged
merged 8 commits into from
Jul 21, 2022

Conversation

dumpsterfireproject
Copy link
Contributor

🤔 What's changed?

I added a go folder with a github.com/cucumber/ci-environment/go module for the go implementation of ci-environment. It includes a Makefile to copy the CiEnvironments.json file into the module, so it can be included using go:embed. I also added the .github/workflows/test-go.yml, and updated the CHANGELOG.md and README.md.

⚡️ What's your motivation?

Fixes #150
Adds new functionality - a Go implementation of ci-environment to be used for the message formatter in the Godog project.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

Beyond any feedback on the code itself, if there is anything else required to better fit in with the release process, please let me know.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@dumpsterfireproject dumpsterfireproject marked this pull request as draft July 20, 2022 01:57
@dumpsterfireproject dumpsterfireproject marked this pull request as ready for review July 20, 2022 02:18
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you very much!

Do you think you could try to add some paragraph and some hierarchy into the README? It is nice to have added one to explain the spec of the go implementation. It just look a little bit hard to read as it is a huge block of text 😅

And the acceptance tests are missing. If you look at the other implementation (ruby, javascript), you'll find tests as part of the regular test suites that perform some checks based on the the ../testdata folder. Do you think you could do the same? Would you need more info?

.github/workflows/test-go.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, you are right. I missed the acceptance tests on my first review.

I did not looked where I expected those to be

Well, nice work, thank you!
And thanks for the release workflow too 🤩

@aurelien-reeves aurelien-reeves merged commit d0a4a15 into main Jul 21, 2022
@aurelien-reeves aurelien-reeves deleted the 150-add-ci-environment-implementation-in-go branch July 21, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ci-environment implementation in Go
3 participants