-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Use a message based usage formatter #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the usage formatter to be useful too. Does change the json structure significantly.
11 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Use a message based usage formatter.
The
--plugin usage
now produces a human readable report where for each step definition usage statistics are calculated. Individual durations for each step are also included.With this implementation any unused step definitions also automatically show up in the report as step definitions without steps. This also allow the report to be reused for the unused steps formatter.
A
--plugin usage-json
was added to provide a json based report. This reports structure differs significantly from the original json output from the usage plugin.⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Previously the output would calculate the average and median duration for each pickle step.
This is only useful if the same pickle step rather than the same step definition is used repeatedly - and presumably that doesn't happen too much. Looking at #214 I also can't work out what the rationale for this structure is supposed to be.
Further more, we don't have any sort of analytics as to whether this is formatter is used at all. So I'm completely in the dark here. If you did find this old useful and the new
usage-json
formatter does not work for you, please create a new issue and explain why.📋 Checklist:
usage-json
formatter that renders json output