Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby / Rubocop bump #71

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regenerate TODO file with new version of rubocop and some cops fixed
luke-hill committed Sep 26, 2024
commit 2dbe66b4323b6f496a2527dfcb43714c13ea55b6
69 changes: 9 additions & 60 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,49 +1,31 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-12-21 16:12:21 UTC using RuboCop version 1.44.1.
# on 2024-09-26 14:25:12 UTC using RuboCop version 1.66.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# TODO: Nov '23 -> 25 files inspected, 132 offenses detected, 102 offenses autocorrectable
# TODO: Nov '23 -> 25 files inspected, 53 offenses detected, 28 offenses autocorrectable

# Offense count: 4
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented, indented_relative_to_receiver
Layout/MultilineMethodCallIndentation:
Exclude:
- 'lib/cucumber/wire/request_handler.rb'
# TODO: Sep '24 -> 25 files inspected, 37 offenses detected, 19 offenses autocorrectable

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
- 'features/step_definitions/wire_steps.rb'
- 'features/support/fake_wire_server.rb'

# Offense count: 2
# Configuration parameters: AllowedMethods.
# AllowedMethods: enums
Lint/ConstantDefinitionInBlock:
Exclude:
- 'spec/cucumber/wire/connection_spec.rb'

# Offense count: 1
Lint/RescueException:
Exclude:
- 'features/support/fake_wire_server.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Lint/ToJSON:
Exclude:
- 'lib/cucumber/wire/data_packet.rb'

# Offense count: 1
# Configuration parameters: AutoCorrect.
Lint/UselessAssignment:
Exclude:
- 'lib/cucumber/wire/connection.rb'
@@ -54,12 +36,12 @@ Lint/UselessRescue:
- 'features/support/fake_wire_server.rb'

# Offense count: 2
# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 21

# Offense count: 2
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
Metrics/MethodLength:
Max: 13

@@ -83,15 +65,13 @@ RSpec/ExampleLength:

# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: .
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example
RSpec/HookArgument:
EnforcedStyle: each

# Offense count: 2
RSpec/LeakyConstantDeclaration:
Exclude:
- 'spec/cucumber/wire/configuration_spec.rb'
- 'spec/cucumber/wire/connection_spec.rb'
- 'spec/cucumber/wire/exception_spec.rb'

# Offense count: 3
RSpec/MultipleExpectations:
@@ -104,28 +84,12 @@ RSpec/VerifiedDoubles:
- 'spec/cucumber/wire/connection_spec.rb'
- 'spec/cucumber/wire/connections_spec.rb'

# Offense count: 2
Rake/Desc:
Exclude:
- 'Rakefile'

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
Security/YAMLLoad:
Exclude:
- 'lib/cucumber/wire/configuration.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
# FunctionalMethods: let, let!, subject, watch
# AllowedMethods: lambda, proc, it
Style/BlockDelimiters:
Exclude:
- 'features/step_definitions/wire_steps.rb'

# Offense count: 2
Style/ClassVars:
Exclude:
@@ -155,14 +119,6 @@ Style/MutableConstant:
Exclude:
- 'lib/cucumber/wire/configuration.rb'

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
Style/ParallelAssignment:
Exclude:
- 'features/support/fake_wire_server.rb'
- 'lib/cucumber/wire/data_packet.rb'
- 'lib/cucumber/wire/step_argument.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Style/RescueModifier:
@@ -183,10 +139,3 @@ Style/RescueStandardError:
Style/Semicolon:
Exclude:
- 'lib/cucumber/wire/connection.rb'

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Mode.
Style/StringConcatenation:
Exclude:
- 'features/support/fake_wire_server.rb'