[.NET] Removed dependency on System.Text.Json for improved startup time#338
Merged
gasparnagy merged 1 commit intocucumber:mainfrom Dec 24, 2024
Merged
[.NET] Removed dependency on System.Text.Json for improved startup time#338gasparnagy merged 1 commit intocucumber:mainfrom
gasparnagy merged 1 commit intocucumber:mainfrom
Conversation
b843c5d to
6492a35
Compare
gasparnagy
approved these changes
Dec 24, 2024
Member
gasparnagy
left a comment
There was a problem hiding this comment.
These are great improvements of the performance. I'm fine with it.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR replaces reading reading
gherkin-languages.jsonon runtime with a precompiled step (roslyn source generator). This reduces the runtime overhead for startup/coldstart and removes dependencies (and with them jit time).Results before:
Results after:
Bonus Comparions with RunStrategy.ColdStart
Note:
RunStrategy.ColdStartis not very stable, so take this with a little salt.Results before:
Results after:
⚡️ What's your motivation?
Speedup startup time when gherkin parser is used in visual studio plugin or or while compiling.
Also reducing the public needed dependencies of the project, so hopefully less needed (security) updates.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
gherkin-languages.jsonis referenced directly and doesn't get copied in the makefile. I thought this is clearer and avoid duplicate files in the repro, but I'm not 100% sure if there are other reasons for it.📋 Checklist: