Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop redundant Python test workflow dependencies #340

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Dec 28, 2024

🤔 What's changed?

  • Dropped pip, setuptools, twine, wheel installations before 'Run tests' step in test workflow
  • Ignored *.egg-info/ build artefact in .gitignore
  • Switched to long option names such as --requirement and --editable

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

  • Intended to switch from a development (or editable) -e installation to a standard installation to ensure we test against a clean build - though retaining as only suffices to install test dependencies at present - as we do not test against a clean package build - see python: Test against build package #322. To be resolved in a separate pull request.

📋 Checklist:

- Remove redundant `setuptools` and `wheel` installation
- Ignore `*.egg-info/` build artefact in `.gitignore`
- Use long option names for readability
@kieran-ryan kieran-ryan added the 🏦 debt Tech debt label Dec 28, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review December 28, 2024 23:43
@kieran-ryan kieran-ryan self-assigned this Dec 28, 2024
Test job does not run against package build. So building the package
twice (pre and post test) is unneccessary. An editable installation
ensures neccessary dependecies are installed without copying files, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant