ci: drop redundant Python test workflow dependencies #340
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
pip
,setuptools
,twine
,wheel
installations before 'Run tests' step in test workflow*.egg-info/
build artefact in.gitignore
--requirement
and--editable
⚡️ What's your motivation?
setuptools
andwheel
are specified as build dependencies in the pyproject.toml file and thus will install on build commands - such aspip install .
orpython -m build
- without explicitly installing them directly [See Remove explicit installation of setuptools nodejs/gyp-next#278]pip install pip
will only keep the same version - thoughpip install --upgrade pip
would update pip if a later version was availabletwine
usage has been dropped from theRun tests
step and migrated to theBuild package
step where it is additionally installed🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
-e
installation to a standard installation to ensure we test against a clean build - though retaining as only suffices to install test dependencies at present - as we do not test against a clean package build - see python: Test against build package #322. To be resolved in a separate pull request.📋 Checklist: