added "ambigous" to the help text

flags.go

@@ -121,7 +121,7 @@ func BindFlags(prefix string, set *flag.FlagSet, opt *Options) {
 	set.BoolVar(&opt.ShowStepDefinitions, prefix+"definitions", defShowStepDefinitions, "Print all available step definitions.")
 	set.BoolVar(&opt.ShowStepDefinitions, prefix+"d", defShowStepDefinitions, "Print all available step definitions.")
 	set.BoolVar(&opt.StopOnFailure, prefix+"stop-on-failure", defStopOnFailure, "Stop processing on first failed scenario.")
-	set.BoolVar(&opt.Strict, prefix+"strict", defStrict, "Fail suite when there are pending or undefined steps.")
+	set.BoolVar(&opt.Strict, prefix+"strict", defStrict, "Fail suite when there are pending or undefined or ambiguous steps.")
 	set.BoolVar(&opt.NoColors, prefix+"no-colors", defNoColors, "Disable ansi colors.")
 	set.Var(&randomSeed{&opt.Randomize}, prefix+"random", descRandomOption)
 	set.BoolVar(&opt.ShowHelp, "godog.help", false, "Show usage help.")

internal/flags/flags.go

@@ -39,7 +39,7 @@ built-in formatters are:
 
 	flagSet.BoolVarP(&opts.ShowStepDefinitions, prefix+"definitions", "d", opts.ShowStepDefinitions, "print all available step definitions")
 	flagSet.BoolVar(&opts.StopOnFailure, prefix+"stop-on-failure", opts.StopOnFailure, "stop processing on first failed scenario")
-	flagSet.BoolVar(&opts.Strict, prefix+"strict", opts.Strict, "fail suite when there are pending or undefined steps")
+	flagSet.BoolVar(&opts.Strict, prefix+"strict", opts.Strict, "fail suite when there are pending or undefined or ambigous steps")
 
 	flagSet.Int64Var(&opts.Randomize, prefix+"random", opts.Randomize, `randomly shuffle the scenario execution order
   --random

internal/flags/options.go

@@ -38,7 +38,7 @@ type Options struct {
 	// Stops on the first failure
 	StopOnFailure bool
 
-	// Fail suite when there are pending or undefined steps
+	// Fail suite when there are pending or undefined or ambiguous steps
 	Strict bool
 
 	// Forces ansi color stripping

internal/formatters/fmt_multi_test.go

@@ -1,153 +1,153 @@
-package formatters
-
-import (
-	"errors"
-	"testing"
-
-	"github.com/cucumber/godog/formatters"
-	messages "github.com/cucumber/messages/go/v21"
-	"github.com/stretchr/testify/assert"
-)
-
-var (
-	mock = DummyFormatter{}
-
-	document   = &messages.GherkinDocument{}
-	str        = "theString"
-	byt        = []byte("bytes")
-	pickle     = &messages.Pickle{}
-	step       = &messages.PickleStep{}
-	definition = &formatters.StepDefinition{}
-	err        = errors.New("expected")
-)
-
-// TestRepeater tests the delegation of the repeater functions.
-func TestRepeater(t *testing.T) {
-
-	mock.tt = t
-	f := make(repeater, 0)
-	f = append(f, &mock)
-
-	f.Feature(document, str, byt)
-	f.TestRunStarted()
-	f.Pickle(pickle)
-	f.Defined(pickle, step, definition)
-	f.Passed(pickle, step, definition)
-	f.Skipped(pickle, step, definition)
-	f.Undefined(pickle, step, definition)
-	f.Failed(pickle, step, definition, err)
-	f.Pending(pickle, step, definition)
-	f.Ambiguous(pickle, step, definition, err)
-
-	assert.Equal(t, 1, mock.CountFeature)
-	assert.Equal(t, 1, mock.CountTestRunStarted, 1)
-	assert.Equal(t, 1, mock.CountPickle, 1)
-	assert.Equal(t, 1, mock.CountDefined, 1)
-	assert.Equal(t, 1, mock.CountPassed, 1)
-	assert.Equal(t, 1, mock.CountSkipped, 1)
-	assert.Equal(t, 1, mock.CountUndefined, 1)
-	assert.Equal(t, 1, mock.CountFailed, 1)
-	assert.Equal(t, 1, mock.CountPending, 1)
-	assert.Equal(t, 1, mock.CountAmbiguous, 1)
-
-}
-
-type DummyFormatter struct {
-	*Base
-
-	tt                  *testing.T
-	CountFeature        int
-	CountTestRunStarted int
-	CountPickle         int
-	CountDefined        int
-	CountPassed         int
-	CountSkipped        int
-	CountUndefined      int
-	CountFailed         int
-	CountPending        int
-	CountAmbiguous      int
-}
-
-// SetStorage assigns gherkin data storage.
-// func (f *DummyFormatter) SetStorage(st *storage.Storage) {
-// }
-
-// TestRunStarted is triggered on test start.
-func (f *DummyFormatter) TestRunStarted() {
-	f.CountTestRunStarted++
-}
-
-// Feature receives gherkin document.
-func (f *DummyFormatter) Feature(d *messages.GherkinDocument, s string, b []byte) {
-	assert.Equal(f.tt, document, d)
-	assert.Equal(f.tt, str, s)
-	assert.Equal(f.tt, byt, b)
-	f.CountFeature++
-}
-
-// Pickle receives scenario.
-func (f *DummyFormatter) Pickle(p *messages.Pickle) {
-	assert.Equal(f.tt, pickle, p)
-	f.CountPickle++
-}
-
-// Defined receives step definition.
-func (f *DummyFormatter) Defined(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-	f.CountDefined++
-}
-
-// Passed captures passed step.
-func (f *DummyFormatter) Passed(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-	f.CountPassed++
-}
-
-// Skipped captures skipped step.
-func (f *DummyFormatter) Skipped(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-
-	f.CountSkipped++
-}
-
-// Undefined captures undefined step.
-func (f *DummyFormatter) Undefined(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-
-	f.CountUndefined++
-}
-
-// Failed captures failed step.
-func (f *DummyFormatter) Failed(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition, e error) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-	assert.Equal(f.tt, err, e)
-
-	f.CountFailed++
-}
-
-// Pending captures pending step.
-func (f *DummyFormatter) Pending(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-
-	f.CountPending++
-}
-
-// Ambiguous captures ambiguous step.
-func (f *DummyFormatter) Ambiguous(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition, e error) {
-	assert.Equal(f.tt, pickle, p)
-	assert.Equal(f.tt, s, step)
-	assert.Equal(f.tt, d, definition)
-	f.CountAmbiguous++
-}
+package formatters
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/cucumber/godog/formatters"
+	messages "github.com/cucumber/messages/go/v21"
+	"github.com/stretchr/testify/assert"
+)
+
+var (
+	mock = DummyFormatter{}
+
+	document   = &messages.GherkinDocument{}
+	str        = "theString"
+	byt        = []byte("bytes")
+	pickle     = &messages.Pickle{}
+	step       = &messages.PickleStep{}
+	definition = &formatters.StepDefinition{}
+	err        = errors.New("expected")
+)
+
+// TestRepeater tests the delegation of the repeater functions.
+func TestRepeater(t *testing.T) {
+
+	mock.tt = t
+	f := make(repeater, 0)
+	f = append(f, &mock)
+
+	f.Feature(document, str, byt)
+	f.TestRunStarted()
+	f.Pickle(pickle)
+	f.Defined(pickle, step, definition)
+	f.Passed(pickle, step, definition)
+	f.Skipped(pickle, step, definition)
+	f.Undefined(pickle, step, definition)
+	f.Failed(pickle, step, definition, err)
+	f.Pending(pickle, step, definition)
+	f.Ambiguous(pickle, step, definition, err)
+
+	assert.Equal(t, 1, mock.CountFeature)
+	assert.Equal(t, 1, mock.CountTestRunStarted, 1)
+	assert.Equal(t, 1, mock.CountPickle, 1)
+	assert.Equal(t, 1, mock.CountDefined, 1)
+	assert.Equal(t, 1, mock.CountPassed, 1)
+	assert.Equal(t, 1, mock.CountSkipped, 1)
+	assert.Equal(t, 1, mock.CountUndefined, 1)
+	assert.Equal(t, 1, mock.CountFailed, 1)
+	assert.Equal(t, 1, mock.CountPending, 1)
+	assert.Equal(t, 1, mock.CountAmbiguous, 1)
+
+}
+
+type DummyFormatter struct {
+	*Base
+
+	tt                  *testing.T
+	CountFeature        int
+	CountTestRunStarted int
+	CountPickle         int
+	CountDefined        int
+	CountPassed         int
+	CountSkipped        int
+	CountUndefined      int
+	CountFailed         int
+	CountPending        int
+	CountAmbiguous      int
+}
+
+// SetStorage assigns gherkin data storage.
+// func (f *DummyFormatter) SetStorage(st *storage.Storage) {
+// }
+
+// TestRunStarted is triggered on test start.
+func (f *DummyFormatter) TestRunStarted() {
+	f.CountTestRunStarted++
+}
+
+// Feature receives gherkin document.
+func (f *DummyFormatter) Feature(d *messages.GherkinDocument, s string, b []byte) {
+	assert.Equal(f.tt, document, d)
+	assert.Equal(f.tt, str, s)
+	assert.Equal(f.tt, byt, b)
+	f.CountFeature++
+}
+
+// Pickle receives scenario.
+func (f *DummyFormatter) Pickle(p *messages.Pickle) {
+	assert.Equal(f.tt, pickle, p)
+	f.CountPickle++
+}
+
+// Defined receives step definition.
+func (f *DummyFormatter) Defined(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+	f.CountDefined++
+}
+
+// Passed captures passed step.
+func (f *DummyFormatter) Passed(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+	f.CountPassed++
+}
+
+// Skipped captures skipped step.
+func (f *DummyFormatter) Skipped(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+
+	f.CountSkipped++
+}
+
+// Undefined captures undefined step.
+func (f *DummyFormatter) Undefined(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+
+	f.CountUndefined++
+}
+
+// Failed captures failed step.
+func (f *DummyFormatter) Failed(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition, e error) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+	assert.Equal(f.tt, err, e)
+
+	f.CountFailed++
+}
+
+// Pending captures pending step.
+func (f *DummyFormatter) Pending(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+
+	f.CountPending++
+}
+
+// Ambiguous captures ambiguous step.
+func (f *DummyFormatter) Ambiguous(p *messages.Pickle, s *messages.PickleStep, d *formatters.StepDefinition, e error) {
+	assert.Equal(f.tt, pickle, p)
+	assert.Equal(f.tt, s, step)
+	assert.Equal(f.tt, d, definition)
+	f.CountAmbiguous++
+}