Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix step duration calculation #616

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

iaroslav-ciupin
Copy link
Contributor

πŸ€” What's changed?

⚑️ What's your motivation?

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)
  • ⚑ New feature (non-breaking change which adds new behaviour)
  • πŸ’₯ Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@vearutop
Copy link
Member

vearutop commented Apr 8, 2024

Thank you for fixing this. πŸ‘

@vearutop vearutop merged commit da57dd0 into cucumber:main Apr 8, 2024
6 checks passed
@aslakhellesoy
Copy link
Contributor

Hi @iaroslav-ciupin,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • βœ… Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • πŸ’š Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • πŸ’¬ Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • πŸ™‹ Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak HellesΓΈy
Creator of Cucumber

@iaroslav-ciupin
Copy link
Contributor Author

@vearutop @aslakhellesoy thank you, #615 in this issue I also asked whether we should return duration in nanoseconds or milliseconds? because cucumber-html-reporter expects milliseconds, but this library currently generates nanoseconds which leads to wrong duration in HTML report

@iaroslav-ciupin iaroslav-ciupin deleted the fix-step-duration branch April 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants