-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ambiguous step def detection akin to cucumber jvm #636
Conversation
…t yet recorded in the reports as 'Ambiguous', and no test cases figured out yet
… take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error
…us to make cucumber jvm'
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 83.21% 80.27% -2.94%
==========================================
Files 28 40 +12
Lines 3413 3149 -264
==========================================
- Hits 2840 2528 -312
- Misses 458 502 +44
- Partials 115 119 +4 ☔ View full report in Codecov by Sentry. |
Is there any documentaton for godog to update on this change? |
BTW the coverage results seem quite bogus to me - same on the last PR I made. It reports low coverage on commits from previous work not part of this change. |
Co-authored-by: Viacheslav Poturaev <[email protected]>
Addresses #635
🤔 What's changed?
As discussed on related issue this change adds a behaviour under 'strict' mode to detect ambiguous step definitions.
As per cuke jvm this change also adds the "ambiguous" status to godog which appears in the relevant reports; pretty/json.
⚡️ What's your motivation?
Detection of ambiguous steps is a feature of cucumber and behave but missing from godog.
🏷️ What kind of change is this?
This change is only affective under strict mode.
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.