Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ambiguous step def detection akin to cucumber jvm #636

Merged
merged 11 commits into from
Jul 1, 2024
Merged

ambiguous step def detection akin to cucumber jvm #636

merged 11 commits into from
Jul 1, 2024

Conversation

Johnlon
Copy link
Member

@Johnlon Johnlon commented Jun 28, 2024

Addresses #635

🤔 What's changed?

As discussed on related issue this change adds a behaviour under 'strict' mode to detect ambiguous step definitions.
As per cuke jvm this change also adds the "ambiguous" status to godog which appears in the relevant reports; pretty/json.

⚡️ What's your motivation?

Detection of ambiguous steps is a feature of cucumber and behave but missing from godog.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

This change is only affective under strict mode.

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

…t yet recorded in the reports as 'Ambiguous', and no test cases figured out yet
… take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (153db4e) to head (a6f9c2e).
Report is 12 commits behind head on main.

Files Patch % Lines
suite.go 91.89% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   83.21%   80.27%   -2.94%     
==========================================
  Files          28       40      +12     
  Lines        3413     3149     -264     
==========================================
- Hits         2840     2528     -312     
- Misses        458      502      +44     
- Partials      115      119       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Johnlon
Copy link
Member Author

Johnlon commented Jun 28, 2024

Is there any documentaton for godog to update on this change?

@Johnlon
Copy link
Member Author

Johnlon commented Jun 28, 2024

BTW the coverage results seem quite bogus to me - same on the last PR I made. It reports low coverage on commits from previous work not part of this change.

internal/flags/flags.go Outdated Show resolved Hide resolved
Co-authored-by: Viacheslav Poturaev <[email protected]>
@Johnlon Johnlon merged commit bcf6bce into cucumber:main Jul 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants