Update protobuf schema for Elixir #356
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Manually update the protobuf definition in the elixir module so that the published package includes the new Pickle location field from #308.
⚡️ What's your motivation?
Elixir is still being generated from the protobuf definition per #63, so changing the JSON schema and regenerating code in #308 didn't work for Elixir, and this throws up a problem in cucumber/gherkin#433 when trying to make the corresponding Gherkin change. I'll tackle the code generation separately, but this at least gets Elixir to parity right now.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I've slotted in the new field before other fields in the order which matches the JSON schema change but is a no-no in protobuf - but I think this is okay because we're only using the protobuf definition to generate code and not to to (de)serialisation of data in the protobuf way.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.