Skip to content

Conversation

@davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 19, 2025

🤔 What's changed?

Manually update the protobuf definition in the elixir module so that the published package includes the new Pickle location field from #308.

⚡️ What's your motivation?

Elixir is still being generated from the protobuf definition per #63, so changing the JSON schema and regenerating code in #308 didn't work for Elixir, and this throws up a problem in cucumber/gherkin#433 when trying to make the corresponding Gherkin change. I'll tackle the code generation separately, but this at least gets Elixir to parity right now.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

I've slotted in the new field before other fields in the order which matches the JSON schema change but is a no-no in protobuf - but I think this is okay because we're only using the protobuf definition to generate code and not to to (de)serialisation of data in the protobuf way.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Update protobuf schema for elixir Update protobuf schema for Elixir Nov 19, 2025
@davidjgoss davidjgoss marked this pull request as ready for review November 19, 2025 10:21
@davidjgoss
Copy link
Contributor Author

After discussing offline, we're going to go a different way here - the messages and gherkin impls for elixir will be frozen until #63 is done.

@davidjgoss davidjgoss closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant