Rendu swift TP 1 - #5
Open
kaikoveritch wants to merge 18 commits into
Open
Conversation
…tats and changed some constant attributes to variable. Created a dictionary for nature stat modifiers
…ances/weaknesses and an associated function have been added.
…nd the initialization of a fight
…ne trainer is out of pokemons.
…. A few utility functions for 'battle' were added.
…d). Attack phase in battle was partially implemented (damage dealing).
…check if pokemon has fainted and remove it from the fight. Completed fighting round definition
…unctions. (Status effects damage not implemented yet.)
…ing some functionality to functions.
…ghlited a bug (corrected). Added displays (prints) for the fight's states. Added a seed for the rand() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voilà l'état (je pense) final de mon code. Aller plus loin deviendrait trop vite trop complexe à cause de la quantité brute d'éléments et types qui intéragissent, ce qui n'est pas aidé par le fait que le programme n'est pas très modulaire, notamment à cause de sa création "à tâtons" sans une idée très claire de l'objectif. Il devient aussi plus difficile d'avancer sans pouvoir effectuer des tests exhaustifs des fonctionnalités, ce qui est difficile ici de nouveau par la quantité d'éléments, mais aussi à cause du caractère dynamique (ici random) de l'évolution du combat (un simple check que la bonne valeur est renvoyée ne suffirait pas).