Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DACCESS-491: add survey button to advanced search #2249

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

mhk33
Copy link
Contributor

@mhk33 mhk33 commented Mar 4, 2025

This adds a button at the bottom right of the Advanced Search page that opens a feedback survey in a modal window. I am realizing now that I need to add it to the Edit Advanced Search page as well, but opening the draft PR for feedback from @sarah-cul and @chrisrlc. Thanks!

@mhk33 mhk33 requested review from chrisrlc and sarah-cul March 4, 2025 21:37
@mhk33
Copy link
Contributor Author

mhk33 commented Mar 4, 2025

Here is a screenshot of the button position:

advanced-survey-button

The survey only goes to me right now, so feel free to submit it!

@mhk33 mhk33 marked this pull request as ready for review March 5, 2025 15:02
Copy link
Contributor

@chrisrlc chrisrlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine for me! Looking forward to seeing the feedback!

@mhk33
Copy link
Contributor Author

mhk33 commented Mar 5, 2025

This is the generated markup:

<div id="form_button_4ec70c4ce94729334d3a3a5fe9c5dd1e"><button type="button" data-a11y-dialog-show="lwz-dialog-4ec70c4ce94729334d3a3a5fe9c5dd1e" id="lwz-button-4ec70c4ce94729334d3a3a5fe9c5dd1e" class="lwz-btn lwz-open-button-4ec70c4ce94729334d3a3a5fe9c5dd1e lwz-pointer">Help us improve advanced search!</button></div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants