DACCESS-529 - Use rsolr instead of HTTPClient in BrowseController #2254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://culibrary.atlassian.net/browse/DACCESS-529 - fq param with spaces in call number browse returns HTTPClient::BadResponseError
https://culibrary.atlassian.net/browse/DACCESS-530 - Browse controller does not handle bad responses from Solr
https://culibrary.atlassian.net/browse/DACCESS-531 - Standardize Solr fetch code in browse controller
#handle_request_error
), which logs the error, redirects to browse#index, and displays a flash message.If I had more time, I'd have written more tests to improve code coverage on this area of the code, but I was trying to hustle to include this in next week's sprint deploy. But I don't want to hold anything back, so if anything turns up in the PR review (or if it's too short notice to review this PR before deploy!), I can just sync with Jesi to see if this merits its own off-sprint deploy.