-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPF-584 - Fix remarks top navigation #1389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-debruijn
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
vhande,
grubolsch,
Anahkiasen and
dev-publiq
as code owners
September 16, 2024 09:21
brampauwelyn
approved these changes
Sep 16, 2024
Comment on lines
27
to
39
const allPages: Page[] = [ | ||
{ | ||
component: "Integrations/Index", | ||
key: "integrations", | ||
}, | ||
{ key: "opportunities" }, | ||
{ | ||
key: "prices", | ||
}, | ||
{ key: "documentation" }, | ||
{ component: "Support/Index", key: "support" }, | ||
] as const; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be an idea to add a property visibility
: ['authenticated', 'notAuthenticated'] so you can filter on them?
Suggested change
const allPages: Page[] = [ | |
{ | |
component: "Integrations/Index", | |
key: "integrations", | |
}, | |
{ key: "opportunities" }, | |
{ | |
key: "prices", | |
}, | |
{ key: "documentation" }, | |
{ component: "Support/Index", key: "support" }, | |
] as const; | |
const allPages: Page[] = [ | |
{ | |
component: "Integrations/Index", | |
key: "integrations", | |
visibility: ['authenticated'] | |
}, | |
{ key: "opportunities", visibility: ['notAuthenticated'] }, | |
{ | |
key: "prices", | |
visibility: ['notAuthenticated'] | |
}, | |
{ key: "documentation", visibility: ['notAuthenticated'] }, | |
{ component: "Support/Index", key: "support", visibility: ['authenticated', 'notAuthenticated'] }, | |
] as const; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Ticket: https://jira.uitdatabank.be/browse/PPF-584