Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPF-584 - Fix remarks top navigation #1389

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

simon-debruijn
Copy link
Contributor

Comment on lines 27 to 39
const allPages: Page[] = [
{
component: "Integrations/Index",
key: "integrations",
},
{ key: "opportunities" },
{
key: "prices",
},
{ key: "documentation" },
{ component: "Support/Index", key: "support" },
] as const;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be an idea to add a property visibility: ['authenticated', 'notAuthenticated'] so you can filter on them?

Suggested change
const allPages: Page[] = [
{
component: "Integrations/Index",
key: "integrations",
},
{ key: "opportunities" },
{
key: "prices",
},
{ key: "documentation" },
{ component: "Support/Index", key: "support" },
] as const;
const allPages: Page[] = [
{
component: "Integrations/Index",
key: "integrations",
visibility: ['authenticated']
},
{ key: "opportunities", visibility: ['notAuthenticated'] },
{
key: "prices",
visibility: ['notAuthenticated']
},
{ key: "documentation", visibility: ['notAuthenticated'] },
{ component: "Support/Index", key: "support", visibility: ['authenticated', 'notAuthenticated'] },
] as const;

@simon-debruijn simon-debruijn merged commit 128e8e4 into main Sep 19, 2024
8 checks passed
@simon-debruijn simon-debruijn deleted the PPF-584-fix-remarks-top-navigation branch September 19, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants