PPF-55 Remove the blocked email #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grubolsch
requested review from
LucWollants,
JonasVHG,
brampauwelyn,
simon-debruijn,
vhande,
Anahkiasen and
dev-publiq
as code owners
LucWollants
requested changes
Sep 20, 2024
There was a problem hiding this comment.
I think the binding should also be removed https://github.com/cultuurnet/publiq-platform/blob/main/app/Mails/MailServiceProvider.php#L60
Maybe it's also good to remove it from the config if it is no longer used https://github.com/cultuurnet/appconfig/blob/main/files/platform/docker/env#L45
|
Removed the config: https://github.com/cultuurnet/appconfig/pull/810 Also removed the binding. |
LucWollants
approved these changes
Sep 24, 2024
…ubliq-platform into PPF-55/remove-blocked-email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
No plans for the forseeable future to have a mail when an integration is blocked so let us remove the code.
In case of blocking an integration the servicedesk/partner cell will always contact the integrator before the event.
Ticket: https://jira.uitdatabank.be/browse/PPF-55