Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPF-651 Cleanup config related to Auth0 #1556

Merged
merged 8 commits into from
Dec 2, 2024
Merged

PPF-651 Cleanup config related to Auth0 #1556

merged 8 commits into from
Dec 2, 2024

Conversation

JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Nov 29, 2024 •
edited
Loading

Changed

  • HandleInertiaRequests, config/uitidwidget.php & resources/ts/Components/UitIdWidget.tsx, resources/ts/types/PageProps.ts: Use agnostic oAuthDomain instead of auth0Domain
  • app/Domain/Auth/Controllers/LoginController.php: The keys AUTH0_LOGIN_ROUTE_* are not defined in any present config so the default was already always chosen.
  • config/keycloak.php: The key AUTH0_LOGIN_STRATEGY is not present in any config file so the default was always chosen.
  • env.ci: Remove all auth0-stuff

Removed

  • config/auth0.php

Related PRs

Ticket: https://jira.publiq.be/browse/PPF-651

@JonasVHG JonasVHG marked this pull request as ready for review November 29, 2024 12:44
LucWollants
LucWollants approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I did not test it.

@JonasVHG JonasVHG merged commit 6a008f9 into main Dec 2, 2024
8 checks passed
@JonasVHG JonasVHG deleted the PPF-651 branch December 2, 2024 09:28
@LucWollants LucWollants changed the title PPF-651 PPF-651 Cleanup config related to Auth0 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucWollants LucWollants LucWollants approved these changes

@brampauwelyn brampauwelyn Awaiting requested review from brampauwelyn brampauwelyn is a code owner

@simon-debruijn simon-debruijn Awaiting requested review from simon-debruijn simon-debruijn is a code owner

@vhande vhande Awaiting requested review from vhande vhande is a code owner

@grubolsch grubolsch Awaiting requested review from grubolsch grubolsch is a code owner

@Anahkiasen Anahkiasen Awaiting requested review from Anahkiasen Anahkiasen is a code owner

@dev-publiq dev-publiq Awaiting requested review from dev-publiq dev-publiq is a code owner

Assignees
No one assigned
Labels
wait-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonasVHG @LucWollants