Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-6272 Replace InvalidArgumentException for Invalid Email #1775

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

III-6272 Replace InvalidArgumentException for Invalid Email #1775

wants to merge 5 commits into from

Conversation

JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Sep 5, 2024 •
edited
Loading

Added

  • InvalidEmailAddress: new Exception
  • event-export-faulty-email.json: data file for acceptance tests

Changed

  • EmailAddress: throw new Exception instead of InvalidArgumentException
  • GetUserByEmailRequestHandler, CdbXmlCreatedByToUserIdResolver & EmailAddressTest: catch new InvalidEmailAddress instead of InvalidArgumentException
  • export.feature: Add acceptance test with malformed email.

Ticket: https://jira.publiq.be/browse/III-6272

@JonasVHG JonasVHG marked this pull request as ready for review September 5, 2024 12:25
@JonasVHG JonasVHG marked this pull request as draft September 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucWollants LucWollants Awaiting requested review from LucWollants LucWollants is a code owner

@simon-debruijn simon-debruijn Awaiting requested review from simon-debruijn simon-debruijn is a code owner

@grubolsch grubolsch Awaiting requested review from grubolsch grubolsch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
wait-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JonasVHG