III-5851 - Implementation new design #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brampauwelyn
requested review from
simon-debruijn,
HanneSips and
Anahkiasen
as code owners
Anahkiasen
reviewed
Nov 8, 2023
Anahkiasen
approved these changes
Nov 13, 2023
simon-debruijn
approved these changes
Nov 13, 2023
| const { asPath } = useRouter(); | ||
|
|
||
| const baseUrl = publicRuntimeConfig.baseUrl; | ||
| const currentPath = new URL(asPath, baseUrl).pathname; |
There was a problem hiding this comment.
Doesn't useRouter also expose a normal path?
There was a problem hiding this comment.
I don't remember exactly why but I wasn't able to do what I wanted with the variables exposed by useRouter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Screenshots:
Angular part: cultuurnet/udb3-angular-app#205
Ticket: https://jira.uitdatabank.be/browse/III-5851