III-6365 - Add ownerships managements page #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/pages/organizers/[organizerId]/ownerships/index.page.tsx
Did you find this useful? React with a 👍 or 👎 |
# Conflicts: # src/hooks/api/ownerships.ts # src/pages/organizers/[organizerId]/ownerships/OwnershipsTable.tsx # src/pages/organizers/[organizerId]/ownerships/index.page.tsx
# Conflicts: # src/hooks/api/ownerships.ts # src/pages/organizers/[organizerId]/ownerships/OwnershipsTable.tsx # src/pages/organizers/[organizerId]/ownerships/index.page.tsx
simon-debruijn
requested review from
brampauwelyn,
Anahkiasen and
vhande
as code owners
brampauwelyn
approved these changes
Dec 11, 2024
Anahkiasen
approved these changes
Jan 13, 2025
| ...configuration, | ||
| enabled: !!name && configuration.enabled === true, |
There was a problem hiding this comment.
Should this maybe account for when enabled is not passed as part of configuration? I'm worried it might make enabled always false then 🤔
| const searchParams = new URLSearchParams(); | ||
| if (paginationOptions) { | ||
| searchParams.set('limit', `${paginationOptions.limit}`); | ||
| searchParams.set('offset', `${paginationOptions.start}`); |
There was a problem hiding this comment.
Are the template strings to cast to string or leftover maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Removed
Ticket: https://jira.uitdatabank.be/browse/III-6365