Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-6215 config yml2php #289

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

III-6215 config yml2php #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
261180a
Add config*php to gitignore
JonasVHG Jun 14, 2024
ab7dc09
ConfigFactory use php instead of yml
JonasVHG Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,9 @@
/.default_queries.php
/pkg
/.bundle
# Ignore configuration files
config.php
config.*.php

*.pem
!tests/Http/Authentication/samples/*.pem
11 changes: 3 additions & 8 deletions app/Factory/ConfigFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,15 @@
namespace CultuurNet\UDB3\SearchService\Factory;

use Noodlehaus\Config;
use Noodlehaus\Parser\Yaml;
use Noodlehaus\Parser\Php;

final class ConfigFactory
{
public static function create(string $configDir): Config
{
$configFiles = [
$configDir . '/config.yml',
$configDir . '/facet_mapping_facilities.yml',
$configDir . '/facet_mapping_regions.yml',
$configDir . '/facet_mapping_themes.yml',
$configDir . '/facet_mapping_types.yml',
$configDir . '/features.yml',
$configDir . '/config.php',
];
return Config::load($configFiles, new Yaml());
return Config::load($configFiles, new Php());
}
}
Loading