Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-3558 Improve type hinting to reach PHPStan level 7 #309

Merged
merged 10 commits into from
Aug 22, 2024
Merged

III-3558 Improve type hinting to reach PHPStan level 7 #309

merged 10 commits into from
Aug 22, 2024

Conversation

LucWollants
Copy link
Contributor

Changed

  • Improved various type hints in comments
  • Improved several inline type hints
  • Handle return types of internal PHP methods better

Ticket: https://jira.uitdatabank.be/browse/III-3558

@LucWollants LucWollants marked this pull request as ready for review August 21, 2024 08:23
Base automatically changed from III-3558-use-datetime-factory to main August 22, 2024 07:19
@LucWollants LucWollants merged commit d22e246 into main Aug 22, 2024
6 checks passed
@LucWollants LucWollants deleted the III-3558-improve-hinting-for-level-7 branch August 22, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-debruijn simon-debruijn simon-debruijn approved these changes

@JonasVHG JonasVHG Awaiting requested review from JonasVHG JonasVHG is a code owner

@grubolsch grubolsch Awaiting requested review from grubolsch grubolsch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucWollants @simon-debruijn