Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pure-Go KEM implementations from cloudflare/circl #22

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

stv0g
Copy link
Collaborator

@stv0g stv0g commented Jun 8, 2023

Fixes #4

This is currently blocked by the fact that the circl Classic McEliece implementation does not implement plaintext confirmations and hence has a mismatching ciphertext length in comparison to liboqs:

cloudflare/circl#378 (comment)

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #22 (2715008) into master (674f3cd) will increase coverage by 0.68%.
The diff coverage is 60.52%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   62.62%   63.30%   +0.68%     
==========================================
  Files          20       21       +1     
  Lines        1608     1646      +38     
==========================================
+ Hits         1007     1042      +35     
+ Misses        465      462       -3     
- Partials      136      142       +6     
Files Changed Coverage Δ
crypto_circl.go 60.52% <60.52%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: Steffen Vogel <[email protected]>
@stv0g stv0g marked this pull request as ready for review August 4, 2023 16:09
@stv0g stv0g merged commit 089dd07 into master Aug 4, 2023
6 of 7 checks passed
@stv0g stv0g deleted the circl branch August 4, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider native Go implementations for KEM
1 participant