Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Commit

Permalink
Lint
Browse files Browse the repository at this point in the history
  • Loading branch information
cuong0993 committed Oct 19, 2021
1 parent d453a6f commit 17287b3
Show file tree
Hide file tree
Showing 51 changed files with 1,269 additions and 974 deletions.
194 changes: 194 additions & 0 deletions all_lint_rules.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,194 @@
linter:
rules:
- always_declare_return_types
- always_put_control_body_on_new_line
- always_put_required_named_parameters_first
- always_require_non_null_named_parameters
# - always_specify_types
- always_use_package_imports
- annotate_overrides
- avoid_annotating_with_dynamic
- avoid_bool_literals_in_conditional_expressions
- avoid_catches_without_on_clauses
- avoid_catching_errors
- avoid_classes_with_only_static_members
- avoid_double_and_int_checks
- avoid_dynamic_calls
- avoid_empty_else
- avoid_equals_and_hash_code_on_mutable_classes
- avoid_escaping_inner_quotes
- avoid_field_initializers_in_const_classes
- avoid_function_literals_in_foreach_calls
- avoid_implementing_value_types
- avoid_init_to_null
- avoid_js_rounded_ints
- avoid_multiple_declarations_per_line
- avoid_null_checks_in_equality_operators
- avoid_positional_boolean_parameters
- avoid_print
- avoid_private_typedef_functions
- avoid_redundant_argument_values
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_future
- avoid_returning_null_for_void
- avoid_returning_this
- avoid_setters_without_getters
- avoid_shadowing_type_parameters
- avoid_single_cascade_in_expression_statements
- avoid_slow_async_io
- avoid_type_to_string
- avoid_types_as_parameter_names
- avoid_types_on_closure_parameters
- avoid_unnecessary_containers
- avoid_unused_constructor_parameters
- avoid_void_async
- avoid_web_libraries_in_flutter
- await_only_futures
- camel_case_extensions
- camel_case_types
- cancel_subscriptions
- cascade_invocations
- cast_nullable_to_non_nullable
- close_sinks
- comment_references
- constant_identifier_names
- control_flow_in_finally
- curly_braces_in_flow_control_structures
- depend_on_referenced_packages
- deprecated_consistency
- diagnostic_describe_all_properties
- directives_ordering
- do_not_use_environment
- empty_catches
- empty_constructor_bodies
- empty_statements
- eol_at_end_of_file
- exhaustive_cases
- file_names
- flutter_style_todos
- hash_and_equals
- implementation_imports
- invariant_booleans
- iterable_contains_unrelated_type
- join_return_with_assignment
- leading_newlines_in_multiline_strings
- library_names
- library_prefixes
- library_private_types_in_public_api
- lines_longer_than_80_chars
- list_remove_unrelated_type
- literal_only_boolean_expressions
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_default_cases
- no_duplicate_case_values
- no_logic_in_create_state
- no_runtimeType_toString
- non_constant_identifier_names
- noop_primitive_operations
- null_check_on_nullable_type_parameter
- null_closures
- omit_local_variable_types
- one_member_abstracts
- only_throw_errors
- overridden_fields
- package_api_docs
- package_names
- package_prefixed_library_names
- parameter_assignments
- prefer_adjacent_string_concatenation
- prefer_asserts_in_initializer_lists
- prefer_asserts_with_message
- prefer_collection_literals
- prefer_conditional_assignment
- prefer_const_constructors
- prefer_const_constructors_in_immutables
- prefer_const_declarations
- prefer_const_literals_to_create_immutables
- prefer_constructors_over_static_methods
- prefer_contains
# - prefer_double_quotes
- prefer_equal_for_default_values
- prefer_expression_function_bodies
- prefer_final_fields
- prefer_final_in_for_each
- prefer_final_locals
- prefer_final_parameters
- prefer_for_elements_to_map_fromIterable
- prefer_foreach
- prefer_function_declarations_over_variables
- prefer_generic_function_type_aliases
- prefer_if_elements_to_conditional_expressions
- prefer_if_null_operators
- prefer_initializing_formals
- prefer_inlined_adds
- prefer_int_literals
- prefer_interpolation_to_compose_strings
- prefer_is_empty
- prefer_is_not_empty
- prefer_is_not_operator
- prefer_iterable_whereType
- prefer_mixin
- prefer_null_aware_method_calls
- prefer_null_aware_operators
- prefer_relative_imports
- prefer_single_quotes
- prefer_spread_collections
- prefer_typing_uninitialized_variables
- prefer_void_to_null
- provide_deprecation_message
- public_member_api_docs
- recursive_getters
- require_trailing_commas
- sized_box_for_whitespace
- slash_for_doc_comments
- sort_child_properties_last
- sort_constructors_first
- sort_pub_dependencies
- sort_unnamed_constructors_first
- test_types_in_equals
- throw_in_finally
- tighten_type_of_initializing_formals
- type_annotate_public_apis
- type_init_formals
- unawaited_futures
- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
- unnecessary_const
# - unnecessary_constructor_name
# - unnecessary_final
- unnecessary_getters_setters
- unnecessary_lambdas
- unnecessary_new
- unnecessary_null_aware_assignments
- unnecessary_null_checks
- unnecessary_null_in_if_null_operators
- unnecessary_nullable_for_final_variable_declarations
- unnecessary_overrides
- unnecessary_parenthesis
- unnecessary_raw_strings
- unnecessary_statements
- unnecessary_string_escapes
- unnecessary_string_interpolations
- unnecessary_this
- unrelated_type_equality_checks
- unsafe_html
- use_build_context_synchronously
- use_full_hex_values_for_flutter_colors
- use_function_type_syntax_for_parameters
- use_if_null_to_convert_nulls_to_bools
- use_is_even_rather_than_modulo
- use_key_in_widget_constructors
- use_late_for_private_fields_and_variables
- use_named_constants
- use_raw_strings
- use_rethrow_when_possible
- use_setters_to_change_properties
- use_string_buffers
- use_test_throws_matchers
- use_to_and_as_if_applicable
- valid_regexps
- void_checks
72 changes: 28 additions & 44 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include: package:flutter_lints/flutter.yaml
include: all_lint_rules.yaml
analyzer:
errors:
missing_required_param: error
Expand All @@ -14,48 +14,32 @@ analyzer:
- '**/*.g.dart'
- '**/*.gr.dart'
- '**/*.freezed.dart'
- '**/*.config.dart'
linter:
rules:
always_declare_return_types: true
annotate_overrides: true
avoid_dynamic_calls: true
avoid_types_on_closure_parameters: true
avoid_void_async: true
avoid_web_libraries_in_flutter: true
await_only_futures: true
camel_case_types: true
cancel_subscriptions: true
close_sinks: true
constant_identifier_names: true
control_flow_in_finally: true
directives_ordering: true
empty_statements: true
file_names: true
hash_and_equals: true
implementation_imports: true
invariant_booleans: true
iterable_contains_unrelated_type: true
library_prefixes: true
list_remove_unrelated_type: true
literal_only_boolean_expressions: true
non_constant_identifier_names: true
one_member_abstracts: true
only_throw_errors: true
overridden_fields: true
package_api_docs: true
package_names: true
package_prefixed_library_names: true
prefer_const_constructors: true
prefer_const_literals_to_create_immutables: true
prefer_final_in_for_each: true
prefer_final_locals: true
prefer_mixin: true
prefer_relative_imports: true
sort_unnamed_constructors_first: true
test_types_in_equals: true
throw_in_finally: true
type_annotate_public_apis: true
unawaited_futures: true
unnecessary_brace_in_string_interps: true
unnecessary_getters_setters: true
unnecessary_statements: true

# too verbose
prefer_final_parameters: false

# Too verbose with little value, and this is taken care of by the Flutter devtool anyway.
diagnostic_describe_all_properties: false

# Conflicts with `prefer_single_quotes`
# Single quotes are easier to type and don't compromise on readability.
prefer_double_quotes: false

# This project doesn't use Flutter-style todos
flutter_style_todos: false

# Boring as it sometimes force a line of 81 characters to be split in two.
# As long as we try to respect that 80 characters limit, going slightly
# above is fine.
lines_longer_than_80_chars: false

# Conflicts with disabling `implicit-dynamic`
avoid_annotating_with_dynamic: false

# conflicts with `prefer_relative_imports`
always_use_package_imports: false

public_member_api_docs: false
1 change: 1 addition & 0 deletions lib/app.dart
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import 'package:auto_route/auto_route.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
// ignore: depend_on_referenced_packages
import 'package:flutter_gen/gen_l10n/l10n.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';

Expand Down
11 changes: 6 additions & 5 deletions lib/authentication/authentication_controller.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import '../user/user_repository_impl.dart';
import 'authentication_state.dart';

final authenticationProvider =
StateNotifierProvider<AuthenticationController, AuthenticationState>((ref) {
return AuthenticationController(ref.read);
});
StateNotifierProvider<AuthenticationController, AuthenticationState>(
(ref) => AuthenticationController(ref.read),
);

class AuthenticationController extends StateNotifier<AuthenticationState> {
AuthenticationController(this._read) : super(AuthenticationState.loading()) {
Expand All @@ -20,7 +20,7 @@ class AuthenticationController extends StateNotifier<AuthenticationState> {
await FirebaseAuth.instance.signInAnonymously();
}
state = AuthenticationState.authenticated();
} catch (_) {
} on FirebaseException catch (_) {
state = AuthenticationState.unauthenticated();
}
});
Expand Down Expand Up @@ -48,7 +48,8 @@ class AuthenticationController extends StateNotifier<AuthenticationState> {
Future signInWithFacebook() async {
try {
final loginResult = await _facebookLogin.login(
loginBehavior: LoginBehavior.nativeWithFallback);
loginBehavior: LoginBehavior.nativeWithFallback,
);
final credential =
FacebookAuthProvider.credential(loginResult.accessToken!.token);
await _tryToLinkWithCurrentUser(credential);
Expand Down
Loading

0 comments on commit 17287b3

Please sign in to comment.