scripts: fix ssl builds on x86_64 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libssl.a is installed on `$PREFIX/lib64/` on x86_64 builds, and the scripts here are not aware of this location. Always use `$PREFIX/lib/` to keep things uniform.
|
I do the same thing in Ubuntu. It's strange that OpenSSL decided to make lib64 the default even in distros that don't use it. Also I set rpath but use |
bagder
reviewed
Dec 14, 2023
| @@ -37,6 +37,7 @@ pushd ${SRCDIR} | |||
|
|
|||
| # Build the library. | |||
| ${ARCH_PROG} ./config --prefix=${INSTALLDIR} \ | |||
| --libdir=lib \ | |||
There was a problem hiding this comment.
Does this work with a relative name or should it rather be ${INSTALLDIR}/lib ?
There was a problem hiding this comment.
Yes, --libdir from OpenSSL can take relative paths:
bagder
added a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libssl.a is installed on
$PREFIX/lib64/on x86_64 builds, and the scripts here are not aware of this location. Always use$PREFIX/lib/to keep things uniform.