-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor contributing docs #1866
base: main
Are you sure you want to change the base?
minor contributing docs #1866
Conversation
done again due to messing up in #1857 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with minor comment!
docs/contributing/CONTRIBUTING.md
Outdated
@@ -45,22 +45,22 @@ extension](#running--testing-extension-locally). You may also find the [VSCode A | |||
|
|||
where `some.extension` is the id of the extension you'd like to install into the sandbox | |||
|
|||
6. Copy / symlink `cursorless-talon-dev` into your Talon user directory for some useful voice commands for developing Cursorless. | |||
6. Copy / symlink [`cursorless-talon-dev`](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon-dev) into your Talon user directory for some useful voice commands for developing Cursorless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally use relative links when they're inside the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer relative links. but when I look through the code base we haven't really been too rigorous about that unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can believe that, but I don't that's an argument against changing this to a relative link, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope
@@ -45,22 +45,22 @@ extension](#running--testing-extension-locally). You may also find the [VSCode A | |||
|
|||
where `some.extension` is the id of the extension you'd like to install into the sandbox | |||
|
|||
6. Copy / symlink `cursorless-talon-dev` into your Talon user directory for some useful voice commands for developing Cursorless. | |||
6. Copy / symlink [`cursorless-talon-dev`](cursorless/cursorless-talon-dev) into your Talon user directory for some useful voice commands for developing Cursorless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link looks wrong, no?
Checklist