Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vscode api get configuration #2129

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Dec 13, 2023

I have on purpose not migrated all references to vscode.workspace.getConfiguration because we might need to have a discussion if this is a preferable implementation first.

Checklist

  • [-] I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson added the to discuss Plan to discuss at meet-up label Dec 16, 2023
@pokey
Copy link
Member

pokey commented Dec 19, 2023

not sure I'm in love with having something on vscodeApi that doesn't exactly mirror vscode api, as that's kind of what that object is for. I don't feel super strongly tho, so maybe let's discuss. We could maybe put it somewhere else

Comment on lines 15 to 19
workspace: {
getConfiguration,
watchConfiguration,
onDidChangeConfiguration,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@AndreasArvidsson AndreasArvidsson Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Unfortunately now we lost all improvements in mocking settings that I had originally introduced.

@pokey pokey removed the to discuss Plan to discuss at meet-up label Jan 4, 2024
@AndreasArvidsson AndreasArvidsson marked this pull request as draft August 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants