Skip to content

Prevent whitespace from passing honeypot checks #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthonymfowler15 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent whitespace from passing honeypot checks #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/honeypot-captcha.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def honeypot_style_class
end

def protect_from_spam
head :ok if honeypot_fields.any? { |f,l| !params[f].blank? }
head :ok if honeypot_fields.any? { |f,l| !params[f].blank? || params[f].to_s.length > 0 }
Copy link
Contributor

@sunny sunny Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could be simplified to the one string value we allow:

Suggested change
head :ok if honeypot_fields.any? { |f,l| !params[f].blank? || params[f].to_s.length > 0 }
head :ok if honeypot_fields.any? { |f, _| params[f].to_s != "" }

end

def self.included(base) # :nodoc:
Expand Down