Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: continue develop scrvusd #610

Merged
merged 83 commits into from
Feb 14, 2025
Merged

feat: continue develop scrvusd #610

merged 83 commits into from
Feb 14, 2025

Conversation

OnlyJousting
Copy link
Contributor

@OnlyJousting OnlyJousting commented Jan 20, 2025 •
edited
Loading

Add a Statistics section to scrvUSD page of the loan section.

  • Add historical yield chart for scrvusd displayed in visible time ranges of 1 month, 6 months or 1 year
  • Add historical distribtions for scrvusd displayed in a bar chart
  • Refactor User Position module
  • Refactor components to new theme and component system

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 11:00am
curve-dapp-crvusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 11:00am
curve-dapp-dao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 11:00am
curve-dapp-lend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 11:00am
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 11:00am

0xAlunara
0xAlunara requested changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@0xAlunara 0xAlunara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks, looks good otherwise. Frankly I just want it merged at this point 😅

Copying the values from the metrics gives an ugly unformatted snackbar

image
image
image

apps/main/src/loan/components/PageCrvUsdStaking/UserInformation/index.tsx Outdated Show resolved Hide resolved
apps/main/src/loan/components/PageCrvUsdStaking/UserInformation/index.tsx Outdated Show resolved Hide resolved
packages/curve-ui-kit/src/shared/icons/YieldGrowth.tsx Outdated Show resolved Hide resolved
apps/main/src/loan/entities/scrvusdStatistics.ts Show resolved Hide resolved
@OnlyJousting OnlyJousting requested review from 0xAlunara and DanielSchiavini and removed request for 0xAlunara February 13, 2025 19:19
@OnlyJousting OnlyJousting merged commit fca37ed into main Feb 14, 2025
4 of 5 checks passed
@OnlyJousting OnlyJousting deleted the feat/continue-develop-scrvusd branch February 14, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielSchiavini DanielSchiavini DanielSchiavini approved these changes

@0xAlunara 0xAlunara 0xAlunara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnlyJousting @DanielSchiavini @0xAlunara