Fix issue with blocked communication and reload #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kannut
commented
Mar 15, 2025
custom_components/zaptec/api.py
Outdated
| receiver = servicebus_client.get_subscription_receiver( | ||
| topic_name=conf["Topic"], subscription_name=conf["Subscription"] | ||
| ) | ||
| async with servicebus_client: |
There was a problem hiding this comment.
I see I made this line duplicate
Kannut
commented
Mar 15, 2025
custom_components/zaptec/api.py
Outdated
| topic_name=conf["Topic"], subscription_name=conf["Subscription"] | ||
| ) | ||
| async with servicebus_client: | ||
| receiver = await hass.async_add_executor_job( |
There was a problem hiding this comment.
I did not test this properly. hass is not defined at here. Not sure if this change actually fixes what I thought it did since it seemed to work first time I tried. I can send a restart charger command but not a resume command.
What will the best way be to get hass here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle blocking calls in a better way
In init cancel stream first
Fixes #167