Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manual metric tracking #174

Merged
merged 9 commits into from
Nov 20, 2024

Conversation

Shahroz16
Copy link
Collaborator

@Shahroz16 Shahroz16 requested a review from mrehan27 November 18, 2024 19:16
Copy link

github-actions bot commented Nov 18, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • amiapp_flutter: Build failed. See CI job logs to determine the issue and try re-building.
  • amiapp_flutter: Build failed. See CI job logs to determine the issue and try re-building.
  • amiapp_flutter: 174.9.0 (28868202)

@@ -8,7 +8,7 @@ enum CioLogLevel { none, error, info, debug }
enum Region { us, eu }

/// Enum to specify the type of metric for tracking
enum MetricEvent { delivered, opened, converted, clicked }
enum MetricEvent { delivered, opened, converted }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS SDK doesn't have clicked in its enum.

Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the sample app compilation is failing, can we please fix it?

@Shahroz16 Shahroz16 requested a review from mrehan27 November 19, 2024 10:46
@mrehan27 mrehan27 changed the title chore: manual matric tracking chore: manual metric tracking Nov 19, 2024
Base automatically changed from mbl-637-device-attributes to feature/data-pipelines-support November 19, 2024 15:59
@Shahroz16 Shahroz16 merged commit ce1140c into feature/data-pipelines-support Nov 20, 2024
6 checks passed
@Shahroz16 Shahroz16 deleted the mbl-677-metric-tracking branch November 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants