chore: rename android classes and method extensions #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
mrehan27
commented
Nov 22, 2024
| @@ -39,7 +39,7 @@ flutter: | |||
| platforms: | |||
| android: | |||
| package: io.customer.customer_io | |||
There was a problem hiding this comment.
I think we can rename package to follow more conventional format, but I avoided doing it for now. Happy to make the change if we feel we should go for it.
mrehan27
force-pushed
the
rehan/mbl-657-android-renaming
branch
from
ff97d17 to
577eed9
Compare
mrehan27
force-pushed
the
rehan/mbl-657-android-renaming
branch
from
577eed9 to
1582a99
Compare
Shahroz16
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: MBL-657
Changes
getAsTypeOrNulltogetAsfor simplicity while retaining functionalityCustomerIoPlugintoCustomerIOPluginto align with naming conventionsCustomerIOPluginModuletoNativeModuleBridgefor clarity, as it's an internal class andCustomerIOprefix looked redundant