Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove workaround for semantic-release issue skipping deployment #386

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

levibostian
Copy link
Contributor

semantic-release has fixed the conventional-commits issue in v22. Therefore, we can remove the workaround from our CI configuration. Our CI workflow is setup to automatically download the latest version of semantic-release and all plugins so v22 should be used the next deployment that is done.

@levibostian levibostian marked this pull request as ready for review September 19, 2023 19:40
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN-UIKit: Build failed. See CI job logs to determine the issue and try re-building.
  • CocoaPods-FCM: levi/remove-semantic-release-workaround (1695152529)
  • APN-UIKit: levi/remove-semantic-release-workaround (1695152981)

@levibostian levibostian requested a review from a team September 19, 2023 19:40
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #386 (12f06b5) into main (9dad7f3) will increase coverage by 2.97%.
Report is 120 commits behind head on main.
The diff coverage is 32.87%.

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   56.11%   59.08%   +2.97%     
==========================================
  Files         103      119      +16     
  Lines        1153     4556    +3403     
==========================================
+ Hits          647     2692    +2045     
- Misses        506     1864    +1358     
Files Changed Coverage Δ
...s/Common/Background Queue/ApiSyncQueueRunner.swift 86.11% <ø> (+2.77%) ⬆️
...ces/Common/Background Queue/Type/QueueStatus.swift 100.00% <ø> (ø)
...urces/Common/Background Queue/Type/QueueTask.swift 100.00% <ø> (ø)
...mmon/Background Queue/Type/QueueTaskMetadata.swift 100.00% <ø> (ø)
Sources/Common/Extensions/ResultExtensions.swift 100.00% <ø> (ø)
...rces/Common/Extensions/UserDefaultExtensions.swift 100.00% <ø> (ø)
Sources/Common/Service/HttpRequestRunner.swift 0.00% <ø> (ø)
Sources/Common/Service/HttpRetryPolicy.swift 100.00% <ø> (ø)
Sources/Common/Util/DeviceMetricsGrabber.swift 100.00% <ø> (ø)
Sources/Common/Util/SingleScheduleTimer.swift 66.66% <ø> (ø)
... and 81 more

... and 45 files with indirect coverage changes

@levibostian levibostian merged commit 5adafee into main Sep 25, 2023
10 checks passed
@levibostian levibostian deleted the levi/remove-semantic-release-workaround branch September 25, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants