Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable code coverage for main branch for better reports #389

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

levibostian
Copy link
Contributor

I noticed in a recent PR that changed no source code files, code coverage reports in the PR were weird. I realized it's because PRs compare it's code coverage against the main branch's code coverage. Which, at this time, do not get uploaded.

This PR modifies the CI to generate code coverage on the main branch so PR code coverage reports are more accurate.

@levibostian levibostian requested a review from a team September 28, 2023 15:41
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: levi/codecov-main-coverage (1695988759)
  • APN-UIKit: levi/codecov-main-coverage (1695988717)

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #389 (f469d0a) into main (9dad7f3) will increase coverage by 3.36%.
Report is 124 commits behind head on main.
The diff coverage is 34.07%.

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   56.11%   59.48%   +3.36%     
==========================================
  Files         103      119      +16     
  Lines        1153     4556    +3403     
==========================================
+ Hits          647     2710    +2063     
- Misses        506     1846    +1340     
Files Coverage Δ
...s/Common/Background Queue/ApiSyncQueueRunner.swift 86.11% <ø> (+2.77%) ⬆️
...ces/Common/Background Queue/QueueQueryRunner.swift 100.00% <100.00%> (ø)
.../Common/Background Queue/QueueRequestManager.swift 100.00% <100.00%> (ø)
...rces/Common/Background Queue/QueueRunRequest.swift 95.62% <100.00%> (+5.62%) ⬆️
...ask Data/DeletePushNotificationQueueTaskData.swift 100.00% <100.00%> (ø)
...Queue/Task Data/IdentifyProfileQueueTaskData.swift 100.00% <100.00%> (ø)
...k Data/RegisterPushNotificationQueueTaskData.swift 100.00% <100.00%> (ø)
...ound Queue/Task Data/TrackEventQueueTaskData.swift 100.00% <100.00%> (ø)
...ces/Common/Background Queue/Type/QueueStatus.swift 100.00% <ø> (ø)
...urces/Common/Background Queue/Type/QueueTask.swift 100.00% <ø> (ø)
... and 81 more

... and 45 files with indirect coverage changes

@levibostian levibostian merged commit b0f309f into main Sep 29, 2023
10 checks passed
@levibostian levibostian deleted the levi/codecov-main-coverage branch September 29, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants