Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: module-wise configuration support #410

Merged
merged 15 commits into from
Nov 24, 2023

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Nov 21, 2023

helps: https://github.com/customerio/issues/issues/11648

Changes

  • Decoupled ModuleTopLevelObject from SdkConfig
  • Moved ModuleTopLevelObject to Common in the process of decoupling feature modules from Tracking
  • Removed dependencies on SdkInitializedUtil from modules
  • Added ModuleTopLevelConfig to be used as a placeholder for config classes
  • Added an empty MessagingInAppConfigOptions for the in-app module
  • Commented code for for creating module instances, to be filled in by later PRs

Copy link

github-actions bot commented Nov 21, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN-UIKit: rehan/cdp-module-wise-config (1700655143)

@mrehan27 mrehan27 self-assigned this Nov 21, 2023
@mrehan27 mrehan27 marked this pull request as ready for review November 24, 2023 15:38
@mrehan27 mrehan27 merged commit dc2a557 into shahroz/native-digraph Nov 24, 2023
5 of 7 checks passed
@mrehan27 mrehan27 deleted the rehan/cdp-module-wise-config branch November 24, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants