Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove tracking dependency from push and in-app #412

Merged
merged 26 commits into from
Nov 27, 2023
Merged

refactor: remove tracking dependency from push and in-app #412

merged 26 commits into from
Nov 27, 2023

Conversation

mrehan27
Copy link
Contributor

helps: https://github.com/customerio/issues/issues/11650

Changes

  • Replaced CustomerIOTracking dependency with CustomerIOCommon in feature modules
  • Updated Makefile to remove CioTracking imports from feature modules
  • Removed CioTracking import from feature module files
  • Commented some breaking code with FIXME reminders

@mrehan27 mrehan27 self-assigned this Nov 22, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited
Loading

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.

  • CocoaPods-FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN-UIKit: Build failed. See CI job logs to determine the issue and try re-building.

@mrehan27 mrehan27 changed the title refactor: decouple push and in-app from tracking refactor: remove tracking dependency push and in-app Nov 22, 2023
@mrehan27 mrehan27 changed the title refactor: remove tracking dependency push and in-app refactor: remove tracking dependency from push and in-app Nov 22, 2023
Base automatically changed from rehan/cdp-module-wise-config to shahroz/native-digraph November 24, 2023 15:39
@mrehan27 mrehan27 marked this pull request as ready for review November 24, 2023 15:46
@mrehan27 mrehan27 merged commit eabfcc5 into shahroz/native-digraph Nov 27, 2023
4 of 7 checks passed
@mrehan27 mrehan27 deleted the rehan/cdp-module-deps branch November 27, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shahroz16 Shahroz16 Shahroz16 approved these changes

@levibostian levibostian levibostian approved these changes

Assignees

@mrehan27 mrehan27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrehan27 @levibostian @Shahroz16