refactor: push modules initialization #418

mrehan27 · 2023-11-30T08:36:39Z

helps: https://github.com/customerio/issues/issues/11650

Changes

APN-UIKit AppDelegate fix for MessagingInApp
Updated MessagingPush to initialize only once
Removed configure option from MessagingPush
Updated MessagingPushAPN and MessagingPushFCM initialization methods
Fixed some tests so they compile

….com:customerio/customerio-ios into shahroz/native-digraph

…igraph

…erio-ios into shahroz/datapipeline-module

…io-ios into shahroz/datapipeline-module

…-usage

…io-ios into shahroz/data-pipeline-usage

…ustomerio-ios into rehan/cdp-feature-modules

Co-authored-by: Levi Bostian <[email protected]>

…ustomerio-ios into rehan/cdp-feature-modules

github-actions · 2023-11-30T08:36:54Z

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.

CocoaPods-FCM: Build failed. See CI job logs to determine the issue and try re-building.
APN-UIKit: rehan/cdp-push-module (1701440127)

mrehan27 · 2023-11-30T08:43:24Z

Sources/MessagingPush/MessagingPush.swift

@@ -7,10 +7,10 @@ import Foundation
  */
 public class MessagingPush: ModuleTopLevelObject<MessagingPushInstance>, MessagingPushInstance {
    @Atomic public private(set) static var shared = MessagingPush()
+    @Atomic public private(set) static var moduleConfig: MessagingPushConfigOptions = MessagingPushConfigOptions.Factory.create()


Since we've already implemented this in the upcoming changes for improving push metrics, I've reused the same to avoid introducing another option for the same functionality.

mrehan27 · 2023-11-30T08:43:41Z

Sources/MessagingPush/MessagingPush.swift

+        guard getImplementationInstance() == nil else {
+            logger.info("\(moduleName) module is already initialized. Ignoring redundant initialization request.")
            return


Based on our ongoing slack discussion

mrehan27 · 2023-12-01T10:33:47Z

Sources/MessagingPush/MessagingPush.swift

        logger.info("\(moduleName) module successfully set up with SDK")
    }

-    override public func createImplementationInstance() -> MessagingPushInstance? {
-        MessagingPush.initialize()
-    }


To disable auto initialization for MessagingPush

github-actions · 2023-12-01T13:35:27Z

	Warnings
⚠️	I noticed file `Tests/MessagingInApp/APITest.swift` was modified. That could mean that this pull request is introducing a breaking change to the SDK. If this pull request does introduce a breaking change, make sure the pull request title is in the format: `<type>!: description of breaking change // Example: refactor!: remove onComplete callback from async functions`

Generated by 🚫 dangerJS against 96aa58f

mrehan27 · 2023-12-01T14:10:01Z

Tests/MessagingInApp/MessagingInAppIntegrationTest.swift

With independent module initialization, I think we no longer need this

Shahroz16 added 30 commits November 14, 2023 23:29

move interface to common

2c4c02f

fix tests

4acb489

autogen files update

c5dd664

added a separate module

2a6e2ed

added global digraph

9052f6c

added missing autogen deps

aa51e7c

more sourcery

cd0c93f

auto gen

eab1a51

new annotations

dde26d7

updated shared graph classes

eeec59b

updated files

f4f59e5

mocking test fixed

49b127e

auto

cc1345b

migrated customer io to common

0ff2b8b

Merge branch 'shahroz/cdp-native-refactor-customerio-class' of github…

bd93ebf

….com:customerio/customerio-ios into shahroz/native-digraph

chore: migrated customerio to common (#411)

0528873

Merge branch 'shahroz/cdp-native-refactor-base' into shahroz/native-d…

db961f3

…igraph

Merge branch 'shahroz/native-digraph' of github.com:customerio/custom…

602b8d1

…erio-ios into shahroz/datapipeline-module

auto gen

3f6561d

added the package

e1f78af

added the wrapper methods

8061535

Merge branch 'main-replica-for-cdp' of github.com:customerio/customer…

1bd7e9d

…io-ios into shahroz/datapipeline-module

merge issue

5829181

merge issue

89d9251

converted to class

f3c56a4

added usage for module

9076356

temp fixes to make SDK build

7019381

updated module name

2dcd944

Merge branch 'shahroz/datapipeline-module' into shahroz/data-pipeline…

a2a89c4

…-usage

build issues fixed

47ce982

mrehan27 and others added 10 commits November 29, 2023 14:44

setEventListener update

1962e4d

Merge branch 'main-replica-for-cdp' of github.com:customerio/customer…

638252c

…io-ios into shahroz/data-pipeline-usage

updated methods

ae7be5e

Merge branch 'shahroz/data-pipeline-usage' of github.com:customerio/c…

b434bff

…ustomerio-ios into rehan/cdp-feature-modules

added comments

2b25914

Apply suggestions from code review

d0b3fb5

Co-authored-by: Levi Bostian <[email protected]>

Merge branch 'shahroz/data-pipeline-usage' of github.com:customerio/c…

e562789

…ustomerio-ios into rehan/cdp-feature-modules

apn uikit fix

1609a88

remove configure

7dbe12a

updated init methods

ef888e3

mrehan27 self-assigned this Nov 30, 2023

mrehan27 commented Nov 30, 2023

View reviewed changes

mrehan27 requested a review from a team November 30, 2023 15:29

removed auto-init for push

fde02bd

mrehan27 commented Dec 1, 2023

View reviewed changes

mrehan27 added 2 commits December 1, 2023 16:09

added DIGraphShared to UnitTest

3cbb468

fixed tests

7a76b44

Base automatically changed from rehan/cdp-feature-modules to main-replica-for-cdp December 1, 2023 14:01

mrehan27 added 4 commits December 1, 2023 19:04

Merge branch 'main-replica-for-cdp' into rehan/cdp-push-module

4dfc6de

post merge conflicts

4cee256

auto gen fix

24454a4

post merge conflicts

96aa58f

mrehan27 commented Dec 1, 2023

View reviewed changes

mrehan27 marked this pull request as ready for review December 1, 2023 18:02

levibostian approved these changes Dec 1, 2023

View reviewed changes

Shahroz16 approved these changes Dec 3, 2023

View reviewed changes

mrehan27 merged commit b013660 into main-replica-for-cdp Dec 4, 2023
6 of 9 checks passed

mrehan27 deleted the rehan/cdp-push-module branch December 4, 2023 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: push modules initialization #418

refactor: push modules initialization #418

mrehan27 commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading

mrehan27 Nov 30, 2023

mrehan27 Nov 30, 2023

mrehan27 Dec 1, 2023

github-actions bot commented Dec 1, 2023 •

edited

Loading

mrehan27 Dec 1, 2023

refactor: push modules initialization #418

refactor: push modules initialization #418

Conversation

mrehan27 commented Nov 30, 2023 • edited Loading

Changes

github-actions bot commented Nov 30, 2023 • edited Loading

Sample app builds 📱

mrehan27 Nov 30, 2023

Choose a reason for hiding this comment

mrehan27 Nov 30, 2023

Choose a reason for hiding this comment

mrehan27 Dec 1, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 1, 2023 • edited Loading

mrehan27 Dec 1, 2023

Choose a reason for hiding this comment

mrehan27 commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Dec 1, 2023 •

edited

Loading