Skip to content

Beta message renderer build (DO NOT MERGE) #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

BernardGatt
Copy link
Contributor

Created this PR to have a test env for the beta message renderer.

Copy link

github-actions bot commented Dec 4, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: bernard/html-renderer (1705926989)
  • APN-UIKit: bernard/html-renderer (1705926944)

Copy link

github-actions bot commented Dec 4, 2023

Hey, there @BernardGatt 👋🤖. I'm a bot here to help you.

I think the title of this pull request is not in the correct format. Follow the instructions below and then edit the pull request title to a valid format. I'll check again after you make an edit 👍.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

* main:
  chore(deps): bump the github-action-dependencies group with 1 update (#442)
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1235 lines in your changes are missing coverage. Please review.

Comparison is base (9dad7f3) 56.11% compared to head (211972e) 58.27%.
Report is 148 commits behind head on main.

Files Patch % Lines
.../MessagingInApp/Gist/Managers/MessageManager.swift 12.96% 188 Missing ⚠️
...s/MessagingInApp/Gist/EngineWeb/AnyEncodable.swift 0.00% 178 Missing ⚠️
...agingInApp/Gist/Managers/MessageQueueManager.swift 24.07% 82 Missing ⚠️
Sources/MessagingInApp/Gist/Gist.swift 23.58% 81 Missing ⚠️
...essagingInApp/Gist/Managers/ModalViewManager.swift 0.00% 73 Missing ⚠️
...rces/MessagingInApp/Gist/EngineWeb/EngineWeb.swift 42.34% 64 Missing ⚠️
...gingInApp/Gist/Views/GistModalViewController.swift 0.00% 53 Missing ⚠️
...es/MessagingInApp/Gist/Managers/QueueManager.swift 0.00% 41 Missing ⚠️
...rces/MessagingInApp/Gist/Managers/LogManager.swift 0.00% 39 Missing ⚠️
...agingInApp/Gist/EngineWeb/EngineEventHandler.swift 0.00% 36 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   56.11%   58.27%   +2.15%     
==========================================
  Files         103      122      +19     
  Lines        1153     4740    +3587     
==========================================
+ Hits          647     2762    +2115     
- Misses        506     1978    +1472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* main:
  Codeclimate deployment action (#448)
  docs: fix typo for sample app compilation (#460)
* main:
  chore: prepare for 2.10.2
  fix: ensure messages are only shown once (#468)
  ci: fix lint assertions (#474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant