Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update track public apis #421

Merged
merged 2 commits into from
Dec 6, 2023
Merged

chore: update track public apis #421

merged 2 commits into from
Dec 6, 2023

Conversation

Shahroz16
Copy link
Contributor

An alternate solution to the PR

@Shahroz16 Shahroz16 changed the base branch from main to main-replica-for-cdp December 5, 2023 11:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.

  • CocoaPods-FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN-UIKit: shahroz/remove-track-take-2 (1701776467)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Warnings
⚠️

I noticed file Tests/Tracking/APITest.swift was modified. That could mean that this pull request is introducing a breaking change to the SDK.

If this pull request does introduce a breaking change, make sure the pull request title is in the format:

<type>!: description of breaking change 
// Example:
refactor!: remove onComplete callback from async functions

Generated by 🚫 dangerJS against e2c0831

@Shahroz16 Shahroz16 requested a review from a team December 5, 2023 11:40
@Shahroz16 Shahroz16 mentioned this pull request Dec 5, 2023
Closed
@Shahroz16 Shahroz16 marked this pull request as ready for review December 6, 2023 07:50
@Shahroz16 Shahroz16 merged commit e60e7a2 into main-replica-for-cdp Dec 6, 2023
6 of 9 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/remove-track-take-2 branch December 6, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levibostian levibostian levibostian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shahroz16 @levibostian