Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: track clean-up #486

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Conversation

Shahroz16
Copy link
Contributor

PR for https://linear.app/customerio/issue/MOB-41/track-cleanup

All this PR contains is the removal of the classes, and code that is not being used anymore. It is either being replaced by

  • CDP
  • Event Bus
  • HTTP layer in NSE

Note:

  • There are still some classes that aren't being utilized but i left because they might be utilized later for prep for production, e.g UserAgentUtil
  • Also, the classes needed for migration are left too.

Copy link

github-actions bot commented Jan 23, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN-UIKit: shahroz/track-cleanup (1706102885)

@@ -63,39 +32,6 @@ public protocol Queue: AutoMockable {
}

public extension Queue {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only methods remaining are the ones needed for migration

Comment on lines -4 to -10
case findAccountRegion
case identifyCustomer(identifier: String)
case registerDevice(identifier: String)
case deleteDevice(identifier: String, deviceToken: String)
case trackCustomerEvent(identifier: String)
case pushMetrics
case trackDeliveryMetrics
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used track API, which we don't use anymore

@Shahroz16 Shahroz16 requested a review from a team January 23, 2024 16:22
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scary, but looks good 😅

@Shahroz16 Shahroz16 merged commit 6ee480b into main-replica-for-cdp Jan 24, 2024
4 of 7 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/track-cleanup branch January 24, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants