Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added support for cocoapods #499

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

Shahroz16
Copy link
Contributor

@Shahroz16 Shahroz16 commented Feb 3, 2024

helps unblock https://linear.app/customerio/issue/MBL-49/[spike]-cocoapods-support-for-datapipeline

Analytics forked in is now available on cocoapods and this lets the FCM sample app use it.

Copy link

github-actions bot commented Feb 3, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: shahroz/cocopoads-support (1706966920)
  • APN-UIKit: shahroz/cocopoads-support (1706966909)

Copy link

github-actions bot commented Feb 3, 2024

Warnings
⚠️

Cocoapods files (.podspec) were modified but Swift Package Manager files (Package.) files were not. This is error-prone when updating dependencies in one service but not the other. Double-check that you updated all of the correct files.

Generated by 🚫 dangerJS against e0a98ce

@Shahroz16 Shahroz16 requested a review from a team February 5, 2024 12:36
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Shahroz16 Shahroz16 merged commit aaf55b6 into main-replica-for-cdp Feb 5, 2024
6 of 8 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/cocopoads-support branch February 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants