Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dispatch loading failed event #805

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Sep 5, 2024

part of MBL-480

Changes

  • Removed EngineRoute class as it seemed to be an unnecessary wrapper
  • Dispatched messageLoadingFailed action when an in-app message times out
  • Replaced engineAction.error with engineAction.messageLoadingFailed to simplify and align with Android
  • Cleaned up and simplified the Message class
  • Updated InAppMessageReducer to handle messageLoadingFailed action

@mrehan27 mrehan27 requested a review from Shahroz16 September 5, 2024 13:51
@mrehan27 mrehan27 self-assigned this Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: Build failed. See CI job logs to determine the issue and try re-building.
  • APN-UIKit: rehan/mbl-480-state-fixes (1725637376)

@mrehan27 mrehan27 requested a review from Shahroz16 September 6, 2024 15:45
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mrehan27 mrehan27 merged commit 23bc3f1 into feature/inapp-state-refactor Sep 10, 2024
5 of 8 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-480-state-fixes branch September 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants