-
Notifications
You must be signed in to change notification settings - Fork 23
test: added tests for messaging inapp implementation #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added tests for messaging inapp implementation #812
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
XCTAssertEqual(eventListenerMock.messageActionTakenReceivedArguments?.actionName, givenName) | ||
} | ||
|
||
func test_eventListeners_expectCallListenerForEachEvent() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now the responsibility of Gist
so these tests will be added to its test suite,
SDK binary size reports 📊SDK binary size of this PR
SDK binary size diff report between this PR and the main branch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/inapp-state-refactor #812 +/- ##
================================================================
- Coverage 63.88% 63.59% -0.30%
================================================================
Files 140 148 +8
Lines 5502 6125 +623
================================================================
+ Hits 3515 3895 +380
- Misses 1987 2230 +243 ☔ View full report in Codecov by Sentry. |
helps: MBL-501
changes: